Clear pending commit state after commit validation fails #820
Conversation
…void rollback of state cleanup
| "not retrying intent ID {}. since it is in state Error", | ||
| intent.id, | ||
| ); | ||
| return Err(last_err.unwrap_or(GroupError::Generic( |
There was a problem hiding this comment.
It would be better to make errors like this into concrete enum variants like GroupError::CouldNotBeCommitted with the message as an #[error("Group Intent could not be committed")] rather than throwing everything into the Generic bucket. Should make these errors easy to match on should we need to, + can use the Retryable trait on them which gives us finer grained control over what will/will not be retried
There was a problem hiding this comment.
@insipx I agree, I added a comment on the follow up issue here #822 (comment).
Think it's better to update this error message while looking at that issue so that this category of errors are more cohesive/ better organized. Thanks for the idea though, I'll make sure this gets updated 🙏
Fixes #805
Changes for preventing groups being stuck in a pending-commit state:
https://github.com/xmtp/libxmtp/pull/820/files#diff-202bbf85eac4d977447dc52cf6f01c12b56e9b8e72e579844bfa5bc43862acecR233-R243
process_for_idif they contain db transactions you do not wish to be rolled backhttps://github.com/xmtp/libxmtp/pull/820/files#diff-202bbf85eac4d977447dc52cf6f01c12b56e9b8e72e579844bfa5bc43862acecR244-R246
IntentState::Error, instead return an errorhttps://github.com/xmtp/libxmtp/pull/820/files#diff-202bbf85eac4d977447dc52cf6f01c12b56e9b8e72e579844bfa5bc43862acecR154-R161