Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add group context extensions #11

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

neekolas
Copy link

@neekolas neekolas commented Jan 7, 2024

Problem

OpenMLS doesn't allow group creators to manually set group_context_extensions at the time of group creation. There are special functions for setting the ratchet tree extension and the required capabilities extension, but no generic interface for custom group_context_extensions like ProtectedMetadata that can be configured at the application level.

Solution

  • Adds the ability to add group_context_extensions on the MlsGroupConfigBuilder
  • Pass those extensions down to the CoreGroup builder
  • Adds a test to verify the extensions are being correctly set

@github-actions github-actions bot added the size/m label Jan 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d327edf) 86.21% compared to head (b0e3742) 86.26%.

Files Patch % Lines
openmls/src/group/mls_group/config.rs 62.50% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   86.21%   86.26%   +0.04%     
==========================================
  Files         169      169              
  Lines       19024    19074      +50     
==========================================
+ Hits        16402    16454      +52     
+ Misses       2622     2620       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neekolas neekolas marked this pull request as ready for review January 7, 2024 19:36
@neekolas neekolas requested a review from richardhuaaa January 8, 2024 16:31
@neekolas neekolas merged commit 9b6b977 into main Jan 9, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants