Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteWrapper
traitas _
to avoid name conflictsFrom<&[u8]>
/Vec<u8>
forByteWrapper
impl Trait
in return position forfn aad
@tuddman and I worked out the errors for the
ByteWrapper
trait onaad
. However, using a generic forByteWrapper
eventually requires that a generic be added toMlsGroup
which could create more complication than necessary. There are a few ways forward, but I wanted to gather some context foraad
before continuing.aad
is present on MlsGroup in theload
method:a simple solution is having a
to_vec
fn on ByteWrapper but thenByteWrapper
itself seems redundant.