-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase network timeouts and retries #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
changed the title
WIP Increase network timeouts
Increase network timeouts and retries
Apr 15, 2024
nplasterer
commented
Apr 15, 2024
dbPath = dbPath, | ||
installationId = v3Client?.installationId()?.toHex() ?: "" | ||
) | ||
return buildFromV1Bundle(bundle, options, account) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was duplicate code inside of buildFromV1Bundle
so instead of trying to keep to copies of the code just call into the other one.
xmtp-android/library/src/main/java/org/xmtp/android/library/Client.kt
Lines 285 to 312 in fe5b6e0
val address = v1Bundle.identityKey.publicKey.recoverWalletSignerPublicKey().walletAddress | |
val newOptions = options ?: ClientOptions() | |
val apiClient = | |
GRPCApiClient( | |
environment = newOptions.api.env, | |
secure = newOptions.api.isSecure, | |
) | |
val (v3Client, dbPath) = if (isAlphaMlsEnabled(options)) { | |
runBlocking { | |
ffiXmtpClient( | |
options, | |
account, | |
options?.appContext, | |
v1Bundle, | |
LegacyIdentitySource.STATIC, | |
address | |
) | |
} | |
} else Pair(null, "") | |
return Client( | |
address = address, | |
privateKeyBundleV1 = v1Bundle, | |
apiClient = apiClient, | |
libXMTPClient = v3Client, | |
dbPath = dbPath, | |
installationId = v3Client?.installationId()?.toHex() ?: "" | |
) |
neekolas
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223
I'm seeing the tests pass now even on poor connection.