Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Error handling in listIntroductionPeers(pagination: Pagination?) function #177

Closed
humanagent opened this issue Oct 25, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@humanagent
Copy link
Contributor

humanagent commented Oct 25, 2023

Describe the bug

While debugging, an error log was noticed that originates from the listIntroductionPeers(pagination: Pagination?) function in the Conversations class. The error is caught and printed, but not rethrown, which prevents it from being handled by the client. This issue is to discuss whether this behavior is expected and if any changes are needed.

Screenshot 2023-10-25 at 13 08 34

Steps to reproduce the bug

The error is triggered when calling Conversations.list(). The error message is
"Loading introduction from peers: queryError("query")".

The relevant code is in the listIntroductionPeers(pagination: Pagination?) function:

Sources/XMTP/Conversations.swift startLine: 247 endLine: 273

@humanagent humanagent added the bug Something isn't working label Oct 25, 2023
@daria-github daria-github self-assigned this Nov 2, 2023
@daria-github
Copy link

Closing, as intended -- if there’s bad data in an introduction message then we don’t want to break loading the rest of the introduction messages. Will reopen if this logic creates any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants