Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Conversations and Contacts actors. #161

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Make Conversations and Contacts actors. #161

merged 2 commits into from
Sep 19, 2023

Conversation

nakajima
Copy link
Contributor

Hopefully will fix #159.

This PR also removes some failing v1 tests that are no longer applicable.

@nakajima nakajima requested a review from a team as a code owner September 19, 2023 15:23
nplasterer
nplasterer approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the pod spec

@nakajima nakajima merged commit dbb39bc into main Sep 19, 2023
1 check passed
@nakajima nakajima deleted the use-actors-for-conversations-and-contacts branch September 19, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Framework can cause app to crash due to variable data race with async access
2 participants
@nakajima @nplasterer