Merge pull request #412 from xmtp/np/refactor-client-caching

Find Client by inboxId not address

android/src/main/java/expo/modules/xmtpreactnativesdk/wrappers/GroupWrapper.kt

@@ -17,6 +17,7 @@ class GroupWrapper {
                 GroupPermissions.ADMIN_ONLY -> "admin_only"
             }
             return mapOf(
+                "clientAddress" to client.address,
                 "id" to group.id.toHex(),
                 "createdAt" to group.createdAt.time,
                 "peerInboxIds" to group.peerInboxIds(),

example/src/tests/groupTests.ts

@@ -174,8 +174,8 @@ test('can make a MLS V3 client from bundle', async () => {
   const group1 = await client.conversations.newGroup([anotherClient.address])
 
   assert(
-    group1.clientAddress === client.address,
-    `clients dont match ${client.address} and ${group1.clientAddress}`
+    group1.client.address === client.address,
+    `clients dont match ${client.address} and ${group1.client.address}`
   )
 
   const bundle = await client.exportKeyBundle()
@@ -211,8 +211,8 @@ test('can make a MLS V3 client from bundle', async () => {
   const group = await client2.conversations.newGroup([randomClient.address])
 
   assert(
-    group.clientAddress === client2.address,
-    `clients dont match ${client2.address} and ${group.clientAddress}`
+    group.client.address === client2.address,
+    `clients dont match ${client2.address} and ${group.client.address}`
   )
 
   return true

example/src/tests/tests.ts

@@ -602,8 +602,8 @@ test('can stream messages', async () => {
   })
   await delayToPropogate()
 
-  if (bobConvo.clientAddress !== bob.address) {
-    throw Error('Unexpected client address ' + bobConvo.clientAddress)
+  if (bobConvo.client.address !== bob.address) {
+    throw Error('Unexpected client address ' + bobConvo.client.address)
   }
   if (!bobConvo.topic) {
     throw Error('Missing topic ' + bobConvo.topic)