Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create LibXMTP Client - android #231

Merged
merged 17 commits into from
Feb 6, 2024
Merged

Create LibXMTP Client - android #231

merged 17 commits into from
Feb 6, 2024

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Jan 31, 2024 •
edited
Loading

See #213

This change includes basic group chat functionality on Android:

  • Create a group using a list of addresses
  • list groups for a client
  • refresh group list
  • list members of a group
  • message a group (default text message codec only)
  • refresh messages for a group

nplasterer
nplasterer reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good just a few small comments

android/src/main/java/expo/modules/xmtpreactnativesdk/XMTPModule.kt Outdated
Comment on lines 96 to 98
return runBlocking {
signLegacy(message).toByteArray()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I wonder if this will work for sure worth trying but I almost think that would just give me the bytearray of the signature object

When I think we want something more like this
https://github.com/xmtp/xmtp-android/pull/156/files#diff-2be5e4bd7739dcb1debb7023943ee5544ebef6355405115cf89aa0e0a3ee09edR97-R102

Maybe this would do to get the bytes out of the signature 🤔

Suggested change
return runBlocking {
signLegacy(message).toByteArray()
}
return runBlocking {
signLegacy(message).ecdsaCompact.bytes.toByteArray()
}

android/src/main/java/expo/modules/xmtpreactnativesdk/XMTPModule.kt Show resolved Hide resolved
android/src/main/java/expo/modules/xmtpreactnativesdk/XMTPModule.kt Outdated Show resolved Hide resolved
android/src/main/java/expo/modules/xmtpreactnativesdk/XMTPModule.kt Show resolved Hide resolved
android/src/main/java/expo/modules/xmtpreactnativesdk/XMTPModule.kt Show resolved Hide resolved
@cameronvoell cameronvoell changed the title Create LibXMTP Client Create LibXMTP Client - android Feb 2, 2024
@cameronvoell cameronvoell changed the base branch from main to beta February 6, 2024 17:54
@cameronvoell cameronvoell marked this pull request as ready for review February 6, 2024 18:00
@cameronvoell cameronvoell requested a review from a team as a code owner February 6, 2024 18:00
@cameronvoell cameronvoell merged commit 6a71abb into beta Feb 6, 2024
4 of 5 checks passed
@cameronvoell cameronvoell deleted the cv/group-spike branch February 6, 2024 18:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

🎉 This PR is included in version 1.27.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.28.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.30.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer left review comments

@alexrisch alexrisch alexrisch approved these changes

@humanagent humanagent Awaiting requested review from humanagent

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cameronvoell @nplasterer @alexrisch