Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consent performance improvements #365

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Consent performance improvements #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2791bbf
bump the pod to get the consent fixes
nplasterer Apr 17, 2024
a60c34a
fix: bump android and the pod file
nplasterer Apr 18, 2024
b2e68ba
fix up access to consent entries
nplasterer Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ repositories {
dependencies {
implementation project(':expo-modules-core')
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:${getKotlinVersion()}"
implementation "org.xmtp:android:0.10.3"
implementation "org.xmtp:android:0.10.4"
implementation 'com.google.code.gson:gson:2.10.1'
implementation 'com.facebook.react:react-native:0.71.3'
implementation "com.daveanthonythomas.moshipack:moshipack:1.0.1"
Expand Down
14 changes: 7 additions & 7 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ PODS:
- hermes-engine/Pre-built (= 0.71.14)
- hermes-engine/Pre-built (0.71.14)
- libevent (2.1.12)
- LibXMTP (0.4.4-beta1)
- LibXMTP (0.4.4-beta2)
- Logging (1.0.0)
- MessagePacker (0.4.7)
- MMKV (1.3.4):
Expand Down Expand Up @@ -445,16 +445,16 @@ PODS:
- GenericJSON (~> 2.0)
- Logging (~> 1.0.0)
- secp256k1.swift (~> 0.1)
- XMTP (0.10.2):
- XMTP (0.10.3):
- Connect-Swift (= 0.12.0)
- GzipSwift
- LibXMTP (= 0.4.4-beta1)
- LibXMTP (= 0.4.4-beta2)
- web3.swift
- XMTPReactNative (0.1.0):
- ExpoModulesCore
- MessagePacker
- secp256k1.swift
- XMTP (= 0.10.2)
- XMTP (= 0.10.3)
- Yoga (1.14.0)

DEPENDENCIES:
Expand Down Expand Up @@ -701,7 +701,7 @@ SPEC CHECKSUMS:
GzipSwift: 893f3e48e597a1a4f62fafcb6514220fcf8287fa
hermes-engine: d7cc127932c89c53374452d6f93473f1970d8e88
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
LibXMTP: ac3cbeafe52d0f23b8730c9fa9cffb66b7714a68
LibXMTP: 0c073613451e3850bfcaaab5438b481fe887cd97
Logging: 9ef4ecb546ad3169398d5a723bc9bea1c46bef26
MessagePacker: ab2fe250e86ea7aedd1a9ee47a37083edd41fd02
MMKV: ed58ad794b3f88c24d604a5b74f3fba17fcbaf74
Expand Down Expand Up @@ -751,8 +751,8 @@ SPEC CHECKSUMS:
secp256k1.swift: a7e7a214f6db6ce5db32cc6b2b45e5c4dd633634
SwiftProtobuf: 407a385e97fd206c4fbe880cc84123989167e0d1
web3.swift: 2263d1e12e121b2c42ffb63a5a7beb1acaf33959
XMTP: 9ddbc5b41eb4d4ef3f672bd2648a7979dee55e50
XMTPReactNative: 09b92733e11c71fdb66c7a9907edf33ec287c3eb
XMTP: bf00ef58d4fbcc8ab740145a6303591adf3fb355
XMTPReactNative: fae44562e5e457c66fde8e2613e1dfd3c1a71113
Yoga: e71803b4c1fff832ccf9b92541e00f9b873119b9

PODFILE CHECKSUM: 95d6ace79946933ecf80684613842ee553dd76a2
Expand Down
4 changes: 2 additions & 2 deletions ios/XMTPModule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ public class XMTPModule: Module {
}
let consentList = try await client.contacts.refreshConsentList()

return try consentList.entries.compactMap { entry in
return try await consentList.entriesManager.map.compactMap { entry in
try ConsentWrapper.encode(entry.value)
}
}
Expand All @@ -596,7 +596,7 @@ public class XMTPModule: Module {
guard let client = await clientsManager.getClient(key: clientAddress) else {
throw Error.noClient
}
let entries = await client.contacts.consentList.entries
let entries = await client.contacts.consentList.entriesManager.map

return try entries.compactMap { entry in
try ConsentWrapper.encode(entry.value)
Expand Down
2 changes: 1 addition & 1 deletion ios/XMTPReactNative.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ Pod::Spec.new do |s|
s.source_files = "**/*.{h,m,swift}"
s.dependency 'secp256k1.swift'
s.dependency "MessagePacker"
s.dependency "XMTP", "= 0.10.2"
s.dependency "XMTP", "= 0.10.3"
end
Loading