Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Group Members #402

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Expose Group Members #402

merged 4 commits into from
Jun 3, 2024

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Jun 3, 2024

Part of #401

Exposes the members of a group and their associated addresses

@nplasterer nplasterer self-assigned this Jun 3, 2024
@nplasterer nplasterer changed the base branch from main to beta June 3, 2024 07:05
@nplasterer nplasterer marked this pull request as ready for review June 3, 2024 07:40
@nplasterer nplasterer requested a review from a team as a code owner June 3, 2024 07:40
@nplasterer nplasterer merged commit 4ba132d into beta Jun 3, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the np/group-members branch June 3, 2024 07:59
Copy link

github-actions bot commented Jun 3, 2024

🎉 This PR is included in version 1.34.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@peterferguson
Copy link
Contributor

Super fast shipping 🚀🚀

Copy link

@Saraeutsza Saraeutsza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • AsyncFunction("listMemberAddresses") { (clientAddress: String, groupId: String) -> [String: [String]] in
  • guard let group = try await findGroup(clientAddress: clientAddress, id: groupId) else {
  •   throw Error.conversationNotFound("no group found for \(groupId)")
    
  • }
  • return try group.members.reduce(into: String: [String]) { result, member in
  •   result[member.inboxId] = member.addresses
    
  • }
  • }

Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: senderAddress returns inboxId in 1.34.0-beta.2
5 participants