Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop database before deleting #477

Merged
merged 3 commits into from
Aug 21, 2024
+12 −13
Merged

Drop database before deleting #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3448312
fix: update to latest open mls
nplasterer Aug 20, 2024
a4a23f8
update lock file
nplasterer Aug 20, 2024
0c4a634
fix up the test
nplasterer Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ repositories {
dependencies {
implementation project(':expo-modules-core')
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:${getKotlinVersion()}"
implementation "org.xmtp:android:0.15.3"
implementation "org.xmtp:android:0.15.4"
implementation 'com.google.code.gson:gson:2.10.1'
implementation 'com.facebook.react:react-native:0.71.3'
implementation "com.daveanthonythomas.moshipack:moshipack:1.0.1"
Expand Down
16 changes: 8 additions & 8 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ PODS:
- hermes-engine/Pre-built (= 0.71.14)
- hermes-engine/Pre-built (0.71.14)
- libevent (2.1.12)
- LibXMTP (0.5.7-beta3)
- LibXMTP (0.5.7-beta4)
- Logging (1.0.0)
- MessagePacker (0.4.7)
- MMKV (1.3.9):
Expand Down Expand Up @@ -449,16 +449,16 @@ PODS:
- GenericJSON (~> 2.0)
- Logging (~> 1.0.0)
- secp256k1.swift (~> 0.1)
- XMTP (0.14.6):
- XMTP (0.14.7):
- Connect-Swift (= 0.12.0)
- GzipSwift
- LibXMTP (= 0.5.7-beta3)
- LibXMTP (= 0.5.7-beta4)
- web3.swift
- XMTPReactNative (0.1.0):
- ExpoModulesCore
- MessagePacker
- secp256k1.swift
- XMTP (= 0.14.6)
- XMTP (= 0.14.7)
- Yoga (1.14.0)

DEPENDENCIES:
Expand Down Expand Up @@ -711,7 +711,7 @@ SPEC CHECKSUMS:
GzipSwift: 893f3e48e597a1a4f62fafcb6514220fcf8287fa
hermes-engine: d7cc127932c89c53374452d6f93473f1970d8e88
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
LibXMTP: b6b930f9d2394a560d7f83b02be6ccd789472422
LibXMTP: 794ebc442e5d66ca808b87142bb91bc6c7f4661f
Logging: 9ef4ecb546ad3169398d5a723bc9bea1c46bef26
MessagePacker: ab2fe250e86ea7aedd1a9ee47a37083edd41fd02
MMKV: 817ba1eea17421547e01e087285606eb270a8dcb
Expand Down Expand Up @@ -763,10 +763,10 @@ SPEC CHECKSUMS:
secp256k1.swift: a7e7a214f6db6ce5db32cc6b2b45e5c4dd633634
SwiftProtobuf: 407a385e97fd206c4fbe880cc84123989167e0d1
web3.swift: 2263d1e12e121b2c42ffb63a5a7beb1acaf33959
XMTP: 0f36b44b3922a5933e3487bf09671655e05dcb8d
XMTPReactNative: 71910c6588e526d85583c1f7aeb6c83816747aea
XMTP: 65c9c75509211f99a251cecd0d90a6552c523269
XMTPReactNative: 82df4ffb174a36f0d3e16c842421f2881c55b6a0
Yoga: e71803b4c1fff832ccf9b92541e00f9b873119b9

PODFILE CHECKSUM: 95d6ace79946933ecf80684613842ee553dd76a2
PODFILE CHECKSUM: 0e6fe50018f34e575d38dc6a1fdf1f99c9596cdd

COCOAPODS: 1.15.2
5 changes: 2 additions & 3 deletions example/src/tests/groupTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,10 +859,9 @@
}

const caroGroupMembers = await caroGroups[0].memberInboxIds()
// should be 3 since they wont get new updates to the group after being removed
if (caroGroupMembers.length !== 3) {
if (caroGroupMembers.length !== 2) {
throw new Error(
'num group members should be 3 but was' + caroGroupMembers.length
'num group members should be 2 but was' + caroGroupMembers.length
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this was actually a bug. Should have shown they were removed. See documentation: https://openmls.tech/book/user_manual/remove_members.html

)
}

Expand Down Expand Up @@ -950,7 +949,7 @@
throw Error('Unexpected num groups (should be 1): ' + groups.length)
}

assert(groups[0].members.length == 2, "should be 2")

Check warning on line 952 in example/src/tests/groupTests.ts

View workflow job for this annotation

GitHub Actions / lint 

Expected '===' and instead saw '=='

Check warning on line 952 in example/src/tests/groupTests.ts

View workflow job for this annotation

GitHub Actions / lint 

Replace `"should·be·2"` with `'should·be·2'`

// bo creates a group with alix so a stream callback is fired
// eslint-disable-next-line @typescript-eslint/no-unused-vars
Expand Down
2 changes: 1 addition & 1 deletion ios/XMTPReactNative.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ Pod::Spec.new do |s|
s.source_files = "**/*.{h,m,swift}"
s.dependency 'secp256k1.swift'
s.dependency "MessagePacker"
s.dependency "XMTP", "= 0.14.6"
s.dependency "XMTP", "= 0.14.7"
end
Loading