Noe/fix group streams issues #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… noe/fix-group-streams-issues
nplasterer
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Don't forget to add a semantic commit so a release gets triggered.
| @@ -146,7 +146,7 @@ export default class Conversations< | |||
| const groupsSubscription = XMTPModule.emitter.addListener( | |||
| EventTypes.Group, | |||
| async ({ inboxId, group }: { inboxId: string; group: GroupParams }) => { | |||
| if (this.known[group.id] || this.client.inboxId !== inboxId) { | |||
There was a problem hiding this comment.
The forked group test is still flaky for me so I don't think this fixes it. I'd probably lean more towards reverting this change just in case. But also okay with leaving it if you think it will fix other issues as all the tests seem to be passing.
|
🎉 This PR is included in version 2.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.knownwhen streaming a group because we might call somewhere elselistGroupswhich will mark the group as known but we still want it to get streamed. If there are other effects of this check @nplasterer let's discuss!