Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to support Joi 16 #152

Open
azai91 opened this issue Oct 31, 2019 · 11 comments
Open

Plans to support Joi 16 #152

azai91 opened this issue Oct 31, 2019 · 11 comments
Assignees

Comments

@azai91
Copy link

azai91 commented Oct 31, 2019

Are there plans to support Joi 16?

@WesTyler
Copy link
Member

Hi there, yes absolutely!

I haven't had time to look at the update yet, since I'm expecting it to be a nearly-total rewrite. I anticipate some open time in the next month though.

If you want to take a stab at it and see how much Joi@16 mucks up the Felicity internals, you are more than welcome to! 🎉

@WesTyler
Copy link
Member

WesTyler commented Nov 1, 2019

216 of 231 tests failed

I'm honestly surprised that I had any passing tests when I did the drop in replacement with Joi@16 😆

@WesTyler
Copy link
Member

WesTyler commented Nov 1, 2019

Also, for anyone stumbling upon this a head's up - Felicity@6 with @hapi/joi@16 support will be a dramatic simplification of the api and functionality. I plan to drop the .entityFor method and class functionality entirely, and focus the library on sample data generation.

@mcarballosam
Copy link

Hi everyone, any update on this matter? Thank you

@WesTyler
Copy link
Member

Still in the works, sorry for the delay. My wife recently gave birth to our second kid, so things got a bit hectic. Hoping to finish soon though.

If anyone wants to take a poke, I have a work in progress branch pushed up here

@mcarballosam
Copy link

Still in the works, sorry for the delay. My wife recently gave birth to our second kid, so things got a bit hectic. Hoping to finish soon though.

If anyone wants to take a poke, I have a work in progress branch pushed up here

Thank you, and congrats on the baby!

@thebradbain
Copy link

thebradbain commented Feb 5, 2020

This is super exciting (including the baby, too)! Because I bet your life is pretty hectic right now, just checking in to see if v16 (and possibly in addition, v17?) is still on the roadmap – totally fine if life got in the way! Just wondering if I should plan on using this in an upcoming project or look for alternatives if not

@WesTyler
Copy link
Member

WesTyler commented Feb 5, 2020

(Hey thanks!)
I actually made some good progress on this over this past weekend, so yes it absolutely is still in the works. I hate that it's taking so long...
And I'll be rolling straight into Joi@17 support as soon as I get these last refactors from Joi@16 in. That should be a muuuch lighter lift. Felicity reaches into the internals of Joi, and Joi@16 was nearly a full rewrite of the Joi internals, which is why this update is so complicated and tedious.

Thanks for the patience!

75 of 228 tests failed

FWIW this time last week it was at about 180 of 228 failing 😆

@WesTyler WesTyler self-assigned this Feb 5, 2020
@azai91
Copy link
Author

azai91 commented Apr 30, 2020

Any update on this?

@gxapplications
Copy link

Hello ! Any plan to support v17 directly ? 😁

@WesTyler
Copy link
Member

WesTyler commented Feb 9, 2021

Okay, sorry all, 2020 was.. well... 2020

The fine folks on our China team stepped up and have opened a PR to update directly to Joi@17. Since the Joi@16 update took a back seat for so long, I am going to skip it. [email protected] will leapfrog to Joi@17.

I should have this wrapped up and published out within 1-2 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants