-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans to support Joi 16 #152
Comments
Hi there, yes absolutely! I haven't had time to look at the update yet, since I'm expecting it to be a nearly-total rewrite. I anticipate some open time in the next month though. If you want to take a stab at it and see how much Joi@16 mucks up the Felicity internals, you are more than welcome to! 🎉 |
I'm honestly surprised that I had any passing tests when I did the drop in replacement with Joi@16 😆 |
Also, for anyone stumbling upon this a head's up - Felicity@6 with @hapi/joi@16 support will be a dramatic simplification of the api and functionality. I plan to drop the |
Hi everyone, any update on this matter? Thank you |
Still in the works, sorry for the delay. My wife recently gave birth to our second kid, so things got a bit hectic. Hoping to finish soon though. If anyone wants to take a poke, I have a work in progress branch pushed up here |
Thank you, and congrats on the baby! |
This is super exciting (including the baby, too)! Because I bet your life is pretty hectic right now, just checking in to see if v16 (and possibly in addition, v17?) is still on the roadmap – totally fine if life got in the way! Just wondering if I should plan on using this in an upcoming project or look for alternatives if not |
(Hey thanks!) Thanks for the patience!
FWIW this time last week it was at about 180 of 228 failing 😆 |
Any update on this? |
Hello ! Any plan to support v17 directly ? 😁 |
Okay, sorry all, 2020 was.. well... 2020 The fine folks on our China team stepped up and have opened a PR to update directly to Joi@17. Since the Joi@16 update took a back seat for so long, I am going to skip it. [email protected] will leapfrog to Joi@17. I should have this wrapped up and published out within 1-2 days. |
Are there plans to support Joi 16?
The text was updated successfully, but these errors were encountered: