Merge pull request #309 from RyujiAMANO/fix/create-debugger-problem

fix: Fixed problem with debugger not setting up properly
xoopscube · Nov 15, 2024 · 1ee8a43 · 1ee8a43
2 parents ec7839c + 364d112
commit 1ee8a43
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/html/modules/legacy/class/Legacy_Debugger.class.php b/html/modules/legacy/class/Legacy_Debugger.class.php
@@ -27,7 +27,7 @@ class Legacy_DebuggerManager
      * @param $instance
      * @param $debug_mode
      */
-    public function createInstance(&$instance, $debug_mode)
+    public static function createInstance(&$instance, $debug_mode)
     {
         if (is_object($instance)) {
             return;

diff --git a/html/modules/legacy/kernel/Legacy_Controller.class.php b/html/modules/legacy/kernel/Legacy_Controller.class.php
@@ -95,6 +95,11 @@ class Legacy_Controller extends XCube_Controller
      */
     public $mSetupDebugger = null;
 
+    /**
+     * @var Legacy_AbstractDebugger
+     */
+    public $mDebugger;
+
     /**
      * @public
      * @var XCube_Delegate
@@ -107,8 +112,6 @@ class Legacy_Controller extends XCube_Controller
      * @var XoopsLogger
      */
     public $mLogger = null;
-    //@todo added
-    //public $mDebugger = null;
 
     public function __construct()
     {
@@ -771,7 +774,9 @@ public function _setupScript()
      */
     public function _setupDebugger()
     {
-        error_reporting(0);
+	// Commented out because suppressing errors here will not result in an error if the debugger setup fails.
+	// If the debugger setup succeeds, error_reporting is set to the value corresponding to the debug mode.
+        // error_reporting(0);
 
         $debug_mode = $this->mRoot->mContext->mXoopsConfig['debug_mode'];
         if (defined('XC_FORCE_DEBUG_PHP')) {