Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add stream option in Benchmark #2038

Merged
merged 11 commits into from
Aug 9, 2024
Merged

ENH: Add stream option in Benchmark #2038

merged 11 commits into from
Aug 9, 2024

Conversation

Dawnfz-Lenfeng
Copy link
Contributor

  • Added stream option in benchmark (you can add --stream at the end of the original bash script to use it).
  • Added more details in printing results.

@XprobeBot XprobeBot added the enhancement New feature or request label Aug 7, 2024
@XprobeBot XprobeBot added this to the v0.14.0 milestone Aug 7, 2024
@qinxuye
Copy link
Contributor

qinxuye commented Aug 8, 2024

Could you rebase the main branch to pass the CI?

qinxuye
qinxuye approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@qinxuye qinxuye merged commit a826372 into xorbitsai:main Aug 9, 2024
11 of 13 checks passed
@Dawnfz-Lenfeng Dawnfz-Lenfeng deleted the benchmark branch September 11, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@Dawnfz-Lenfeng @qinxuye @XprobeBot