Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyword service in a gRPC package specifier causes a TypeError #1659

Closed
kennythepark opened this issue Oct 26, 2021 · 2 comments · Fixed by #1660 · May be fixed by xumical/ui#109
Closed

Keyword service in a gRPC package specifier causes a TypeError #1659

kennythepark opened this issue Oct 26, 2021 · 2 comments · Fixed by #1660 · May be fixed by xumical/ui#109
Labels
bug Something isn't working
Milestone
1.5.1

Comments

@kennythepark
Copy link

Describe the bug
Having the keyword service as a gRPC package specifier causes a TypeError in the wrapClientConstructor function. I have attached a minimum reproducible repository with instructions on replicating the bug.

Minimum Reproducible Repository
https://github.com/kennythepark/dd-trace-package-specifier-bug-mrr

Environment

  • Operation system: macOS v11.6
  • Node version: 12.20.1
  • Tracer version: 1.5.0
  • Agent version:
@kennythepark kennythepark added the bug Something isn't working label Oct 26, 2021
@bengl bengl mentioned this issue Oct 26, 2021
Merged
@bengl
Copy link
Collaborator

bengl commented Oct 26, 2021

Hi @kennythepark. I've prepared a fix in #1660, and I've tested it against your sample reproduction app. It seems to fix it accordingly. Would you like to double-check by manually adding the fix from that PR to your app?

@kennythepark
Copy link
Author

Hi @bengl! Just checked manually on the production app, and it solves the problem. Thank you for the fast turnaround!

@rochdev rochdev added this to the 1.5.1 milestone Oct 29, 2021
@xumical xumical mentioned this issue May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.5.1
3 participants
@bengl @rochdev @kennythepark