From 962e394186f17b410a4b595e68cd4d08a990c41b Mon Sep 17 00:00:00 2001
From: Vincent Massol <vincent@massol.net>
Date: Tue, 12 Mar 2019 15:11:14 +0100
Subject: [PATCH] [Misc] Excluding crypto modules from pitest checks, see
 comment in commit and issue at
 https://github.com/STAMP-project/pitest-descartes/issues/62

---
 .../xwiki-commons-crypto/pom.xml              | 24 +++++++++++++++++++
 .../xwiki-commons-crypto-cipher/pom.xml       |  1 -
 .../xwiki-commons-crypto-common/pom.xml       |  1 -
 .../xwiki-commons-crypto-password/pom.xml     |  1 -
 .../xwiki-commons-crypto-pkix/pom.xml         |  1 -
 .../xwiki-commons-crypto-signer/pom.xml       |  1 -
 6 files changed, 24 insertions(+), 5 deletions(-)

diff --git a/xwiki-commons-core/xwiki-commons-crypto/pom.xml b/xwiki-commons-core/xwiki-commons-crypto/pom.xml
index 5837871e2d..3882e2c5c2 100644
--- a/xwiki-commons-core/xwiki-commons-crypto/pom.xml
+++ b/xwiki-commons-core/xwiki-commons-crypto/pom.xml
@@ -69,4 +69,28 @@
     <module>xwiki-commons-crypto-signer</module>
     <module>xwiki-commons-crypto-store</module>
   </modules>
+  <build>
+    <pluginManagement>
+      <plugins>
+        <!-- Exclude Crypto tests from PIT/Descartes since 1) those tests are special (if they don't have enough entropy
+             they execute slowyl which can let to timeouts and break mutation scores and 2) they are very slow to execute
+             and thus take even more time with mutations... -->
+        <plugin>
+          <groupId>org.pitest</groupId>
+          <artifactId>pitest-maven</artifactId>
+          <executions>
+            <execution>
+              <id>pitest-check</id>
+              <goals>
+                <goal>mutationCoverage</goal>
+              </goals>
+              <configuration>
+                <skip>true</skip>
+              </configuration>
+            </execution>
+          </executions>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+  </build>
 </project>
diff --git a/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-cipher/pom.xml b/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-cipher/pom.xml
index 6f8203dee9..832c783e62 100644
--- a/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-cipher/pom.xml
+++ b/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-cipher/pom.xml
@@ -32,7 +32,6 @@
   <description>Provides confidentiality throught encryption</description>
   <properties>
     <xwiki.jacoco.instructionRatio>0.70</xwiki.jacoco.instructionRatio>
-    <xwiki.pitest.mutationThreshold>36</xwiki.pitest.mutationThreshold>
     <!-- Name to display by the Extension Manager -->
     <xwiki.extension.name>Cryptographic Services for Confidentiality</xwiki.extension.name>
   </properties>
diff --git a/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/pom.xml b/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/pom.xml
index 623b0be813..da66a4d0c7 100644
--- a/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/pom.xml
+++ b/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/pom.xml
@@ -32,7 +32,6 @@
   <description>API common to all crypto modules</description>
   <properties>
     <xwiki.jacoco.instructionRatio>0.62</xwiki.jacoco.instructionRatio>
-    <xwiki.pitest.mutationThreshold>69</xwiki.pitest.mutationThreshold>
     <!-- Name to display by the Extension Manager -->
     <xwiki.extension.name>Cryptographic Services Common API</xwiki.extension.name>
     <!-- Cryptography requires complex expressions, allow a few such expressions -->
diff --git a/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-password/pom.xml b/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-password/pom.xml
index b9c7eee9f3..59cadcb35a 100644
--- a/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-password/pom.xml
+++ b/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-password/pom.xml
@@ -32,7 +32,6 @@
   <description>Provides passwords encryption and validation</description>
   <properties>
     <xwiki.jacoco.instructionRatio>0.65</xwiki.jacoco.instructionRatio>
-    <xwiki.pitest.mutationThreshold>81</xwiki.pitest.mutationThreshold>
     <!-- Name to display by the Extension Manager -->
     <xwiki.extension.name>Cryptographic Services for Password Encryption</xwiki.extension.name>
   </properties>
diff --git a/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-pkix/pom.xml b/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-pkix/pom.xml
index f34526dbb3..f50465c7ef 100644
--- a/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-pkix/pom.xml
+++ b/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-pkix/pom.xml
@@ -32,7 +32,6 @@
   <description>Provides X.509 certificates management</description>
   <properties>
     <xwiki.jacoco.instructionRatio>0.76</xwiki.jacoco.instructionRatio>
-    <xwiki.pitest.mutationThreshold>82</xwiki.pitest.mutationThreshold>
     <!-- Name to display by the Extension Manager -->
     <xwiki.extension.name>Cryptographic Services for Authentication</xwiki.extension.name>
     <!-- Working with cryptography requires a lot of classes, relax the coupling requirements -->
diff --git a/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-signer/pom.xml b/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-signer/pom.xml
index 893292ccd4..e6f52faa6a 100644
--- a/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-signer/pom.xml
+++ b/xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-signer/pom.xml
@@ -32,7 +32,6 @@
   <description>Provides integrity using signature</description>
   <properties>
     <xwiki.jacoco.instructionRatio>0.71</xwiki.jacoco.instructionRatio>
-    <xwiki.pitest.mutationThreshold>75</xwiki.pitest.mutationThreshold>
     <!-- Name to display by the Extension Manager -->
     <xwiki.extension.name>Cryptographic Services for Integrity</xwiki.extension.name>
   </properties>