Make "yadm clone --recursive" work as expected. #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --recursive switch was ignored when YADM clones a dotfile repository. This commit causes "yadm clone --recursive" to also clone submodules in one go, similar to what GIT does when given the --recursive switch.
|
I like this idea. I can add some tests for it, and likely add support for paths with --recurse-submodules[=<path>]. And probably support for -j --jobs too. |
|
That's great, thanks. And by the way, I like yadm! I stumbled across it this weekend, and it's just about to give my homeless life as a developer a long-desired shelter :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The --recursive switch was ignored when YADM clones a dotfile repository.
This commit causes "yadm clone --recursive" to also clone submodules
in one go, similar to what GIT does when given the --recursive switch.
What issues does this PR fix or reference?
Previous Behavior
Before, the --recursive switch was ignored when passed to "yadm clone".
New Behavior
Now, "yadm clone --recursive" also clones all submodules belonging to a
dotfile repository.
Have [tests][1] been written for this change?
No, but all of the current tests still pass.
Have these commits been [signed with GnuPG][2]?
No