-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
날씨 앱 [STEP 1] yujeong #39
Open
yujeong-kwon
wants to merge
3
commits into
yagom-academy:rft_3_yujeong
Choose a base branch
from
yujeong-kwon:rft_3_yujeong_step1
base: rft_3_yujeong
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// | ||
// WeatherInfo.swift | ||
// WeatherForecast | ||
// | ||
// Created by 권유정 on 2024/04/18. | ||
// | ||
|
||
import Foundation | ||
import UIKit | ||
|
||
protocol WeatherInfoDelegate { | ||
func refreshNavigationTitle(title: String) | ||
} | ||
|
||
final class WeatherInfo { | ||
|
||
private var delegate: WeatherInfoDelegate | ||
|
||
init(delegate: WeatherInfoDelegate) { | ||
self.delegate = delegate | ||
} | ||
|
||
func fetchWeatherJSON() -> WeatherJSON? { | ||
|
||
let jsonDecoder: JSONDecoder = .init() | ||
jsonDecoder.keyDecodingStrategy = .convertFromSnakeCase | ||
|
||
guard let data = NSDataAsset(name: "weather")?.data else { | ||
return nil | ||
} | ||
|
||
let info: WeatherJSON | ||
do { | ||
info = try jsonDecoder.decode(WeatherJSON.self, from: data) | ||
} catch { | ||
print(error.localizedDescription) | ||
return nil | ||
} | ||
delegate.refreshNavigationTitle(title: info.city.name) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fetchWeatherJSON와는 관련이 없는 로직인것 같은데 따로 메서드로 빼보면 어떨까요? |
||
return info | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Class의 이름이 모델처럼 느껴져서, JSON을 fetch하는 객체가 느껴지도록 하면 좋을 것 같아요!