Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error building on Clang on windows #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rageoholic
Copy link

Clang apparently doesn't implement strdup in the version of libc they
ship. Instead they implement _strdup which is identical. This change
just makes it so that on windows we just call _strdup in yaml_strdup.

Clang apparently doesn't implement strdup in the version of libc they
ship. Instead they implement _strdup which is identical. This change
just makes it so that on windows we just call _strdup in yaml_strdup.
@jeremyevans
Copy link

This patch does not appear to actually change anything, as the ifdef and else sections are identical. Based on the commit message, I think the intention is to use _strdup instead of strdup in the ifdef section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants