Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Likelihood Computation for VE SDE #64

Open
lujiazho opened this issue Jul 23, 2024 · 2 comments
Open

Wrong Likelihood Computation for VE SDE #64

lujiazho opened this issue Jul 23, 2024 · 2 comments

Comments

@lujiazho
Copy link

return -N / 2. * np.log(2 * np.pi * self.sigma_max ** 2) - torch.sum(z ** 2, dim=(1, 2, 3)) / (2 * self.sigma_max ** 2)

I think this line should be

-N / 2. * np.log(2 * np.pi * self.sigma_max ** 2) - torch.sum((z-x) ** 2, dim=(1, 2, 3)) / (2 * self.sigma_max ** 2)

where the x is the initial x0 which should be passed into this function

instead of

-N / 2. * np.log(2 * np.pi * self.sigma_max ** 2) - torch.sum(z ** 2, dim=(1, 2, 3)) / (2 * self.sigma_max ** 2)

isn't it?

@daihuiao
Copy link

As I understand it, the prior probabilities are calculated here, and the final distribution is assumed to be a Gaussian distribution with a mean of 0, so x in (z-x) =0。
In addition, there is no x in the function parameter pass
:)

@lujiazho
Copy link
Author

As I understand it, the prior probabilities are calculated here, and the final distribution is assumed to be a Gaussian distribution with a mean of 0, so x in (z-x) =0。 In addition, there is no x in the function parameter pass :)

Thanks for your reply :) To my understanding, the prior is the p(x_T) which for VE SDE is as below
image
where the mean is actually x0 not 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants