Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix ESLint E2Es failing since v9 release #6444

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ci: fix ESLint E2Es failing since v9 release #6444

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80b2fa4
ci: fix ESLint E2Es failing since v9 release
wojtekmaj Aug 8, 2024
21c71f6
Merge branch 'master' into eslint-e2e
merceyz Aug 11, 2024
78a09ae
Update e2e-eslint-workflow.yml
arcanis Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/e2e-eslint-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
yarn init -p
yarn add eslint

echo '{"rules": {"semi": ["error", "always"]}}' > .eslintrc
echo 'export default {"rules": {"semi": ["error", "always"]}}' > eslint.config.mjs

echo '42;' | tee ok.js
yarn eslint ok.js
Expand All @@ -41,9 +41,17 @@ jobs:
source scripts/e2e-setup-ci.sh

yarn init -p
yarn add eslint typescript @typescript-eslint/parser @typescript-eslint/eslint-plugin

echo '{"parser": "@typescript-eslint/parser", "plugins": ["@typescript-eslint"], "rules": {"@typescript-eslint/explicit-function-return-type": "error"}}' > .eslintrc
yarn add eslint typescript typescript-eslint

cat > eslint.config.mjs <<EOF
import tseslint from 'typescript-eslint';\n
export default tseslint.config({
files: ['**/*.ts'],
plugins: { '@typescript-eslint': tseslint.plugin },
languageOptions: { parser: tseslint.parser },
rules: { '@typescript-eslint/explicit-function-return-type': 'error' }
});
EOF

echo 'const f = (): number => 42;' | tee ok.ts
yarn eslint ok.ts
Expand Down
Loading