Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests #172

Closed
jstashh opened this issue Dec 16, 2021 · 6 comments
Closed

Add unit tests #172

jstashh opened this issue Dec 16, 2021 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jstashh
Copy link
Contributor

jstashh commented Dec 16, 2021 •
edited
Loading

Functionality to cover:

  • simulations
  • deposits
  • withdrawals
  • earnings calculations
  • iron bank interactions
  • the vaults interface
@jstashh jstashh added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 16, 2021
@FiboApe
Copy link
Collaborator

FiboApe commented Jan 12, 2022

Taking this one :D

@pmdaly
Copy link
Contributor

pmdaly commented Jan 12, 2022

@FiboApe are you addressing all 6?

@FiboApe
Copy link
Collaborator

FiboApe commented Jan 17, 2022

@pmdaly yes!

@jstashh
Copy link
Contributor Author

jstashh commented Jan 17, 2022

@FiboApe @pmdaly Maybe it's best to divide this up into smaller tasks that can be tackled distinctly from each other, I believe this will be quite a lot of work

@pmdaly
Copy link
Contributor

pmdaly commented Jan 17, 2022

@jstashh I'd love to tackle a few. @FiboApe if you're interested in splitting some tasks up, let me know which you would like to work on.

@jstashh
Copy link
Contributor Author

jstashh commented Feb 4, 2022

#210
#211
#212
#213
#214
#215

@jstashh jstashh closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pmdaly @jstashh @FiboApe