Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Take out the background color. #30

Open
ghost opened this issue Jan 22, 2014 · 3 comments
Open

Take out the background color. #30

ghost opened this issue Jan 22, 2014 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 22, 2014

Hey,
I think you've made a great plugin, I don't understand why you have a background color property. I just wanted to flip a png image and swap it with another one. Why are you forcing there to be a background color? The flip still works with transparency. I ended up taking out several lines of code to make it work... The background color should be in the CSS, not taken charge with your plugin. Your plugin should only flip stuff.

Having said that, thanks for the plugin. It works and i'm happy with the results :)

@ghost
Copy link
Author

ghost commented Feb 3, 2014

Hey,
Sure, i can tell you what I did. I can't find a copy of the modified
script... I didn't end up using it, so I must of deleted it. However, it's
not that hard, to do. Do a search for the word "color" and delete every
line that has to do with it.

Let me know if it worked.

2014-01-30 pikaboul [email protected]:

Hi,
Can you explain how you did it? I'm facing the same case.

Thank you, and thanks to the plugin author!

Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-33744231
.

@thomasboulongne
Copy link

Your idea was simple, but incredibly efficient and it works like a charm! I still can't understand why the author implemented this color function...
Thank you very much

@ghost
Copy link
Author

ghost commented Feb 3, 2014

Me neither. It's really has nothing to do with the original idea. He's got
lots of code to support rgba colors on old browsers. Who cares! He also
made it impossible to change the background color to transparent in your
CSS.

Oh well, other than that, it's a good plugin!

Glad i could help.
Le 3 févr. 2014 18:09, "pikaboul" [email protected] a écrit :

Your idea was simple, but incredibly efficient and it works like a charm!
I still can't understand why the author implemented this color function...
Thank you very much

Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-34012110
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant