Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor InitDbFixture to skip checkIntegrity for Oracle DB. #20189

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Refactor InitDbFixture to skip checkIntegrity for Oracle DB. #20189

merged 6 commits into from
Jun 12, 2024

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Jun 6, 2024 •
edited
Loading

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #16116

@codecov Codecov
Copy link

codecov bot commented Jun 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 18.34%. Comparing base (ec46ede) to head (18bf9e5).

❗ Current head 18bf9e5 differs from pull request most recent head a7e01b5

Please upload reports for the commit a7e01b5 to get more accurate results.

Files Patch % Lines
framework/test/InitDbFixture.php 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             master   #20189       +/-   ##
=============================================
- Coverage     64.99%   18.34%   -46.65%     
+ Complexity    11391    11389        -2     
=============================================
  Files           430      430               
  Lines         36923    37114      +191     
=============================================
- Hits          23998     6810    -17188     
- Misses        12925    30304    +17379

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark added this to the 2.2.0 milestone Jun 6, 2024
samdark
samdark reviewed Jun 11, 2024
View reviewed changes
framework/CHANGELOG.md Outdated Show resolved Hide resolved
@samdark samdark modified the milestones: 2.2.0, 2.0.50.1 Jun 12, 2024
@samdark samdark merged commit fe5688d into yiisoft:master Jun 12, 2024
81 of 83 checks passed
@terabytesoftw terabytesoftw deleted the fix-integrity-check-db-fixture branch June 12, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@Arhell Arhell Arhell approved these changes

@bizley bizley bizley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.51
Development

Successfully merging this pull request may close these issues.
4 participants
@terabytesoftw @samdark @bizley @Arhell