You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hi, I checked your image transformation part in file utils.py
the formula for rgb to ycbcr image is a little different from Wikipedia:
yours:
y = 16. + (64.738 * img[..., 0] + 129.057 * img[..., 1] + 25.064 * img[..., 2]) / 256.
wiki:
y = 16. + (65.738 * img[..., 0] + 129.057 * img[..., 1] + 25.064 * img[..., 2]) / 256.
and actually in all of your implementations, you use 64.738.
i tested both and seems this minor difference does not affect the prediction accuracy...
but still, want to point out this and make this work better.
The text was updated successfully, but these errors were encountered:
hi, I checked your image transformation part in file utils.py
the formula for rgb to ycbcr image is a little different from Wikipedia:
yours:
y = 16. + (64.738 * img[..., 0] + 129.057 * img[..., 1] + 25.064 * img[..., 2]) / 256.
wiki:
y = 16. + (65.738 * img[..., 0] + 129.057 * img[..., 1] + 25.064 * img[..., 2]) / 256.
and actually in all of your implementations, you use 64.738.
i tested both and seems this minor difference does not affect the prediction accuracy...
but still, want to point out this and make this work better.
The text was updated successfully, but these errors were encountered: