-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The editor content does not sync on different browsers #63
Comments
I can confirm, that I have the same issue. Link to minimal reproduction example: https://github.com/tim-hilt/syncedstore/blob/webrtc-minimal-repro/app/page.tsx It works with |
90% sure this is because the default signaling servers have crashed. Host your own and things seem to work. |
I had problems with firefox using this library, maybe it's related. |
@iamnafets I also have same problem, but I found out that when we console.log peers, they are being added to bcPeers, not to the webrtcPeers. But I dont know how to make them add in the webrtcPeers {
"added": [
"1348b4c7-04f9-465b-98d3-55f1c211926f"
],
"removed": [],
"webrtcPeers": [],
"bcPeers": [
"1348b4c7-04f9-465b-98d3-55f1c211926f"
]
} |
So any news since so long ? It seems to be quite the core functionnality of this lib, right ? |
One year on, and I experience the same issue 😞 |
The problem doesn't fix itself. This is open source. You can fix it yourself. You may also pay me for fixing this issue. Unfortunately, none of my sponsors use this library. I only use it for demos. I will eventually work on this. But I have higher priorities right now. I hope you understand. |
I understand. You caught me in a moment of frustration, I apologise. Thanks for responding. Do we have any clues about where the problem lies? Do you have any intuition? I had some success using a custom signalling server, i.e., running the example server in this repo locally. I got it working between different Firefox containers (i.e., new private window) but not across different browsers. I don't see any errors, so I'm not sure where to begin. One thought I had was, is it CORS related? But I ran the signalling server from the same domain, and then I realised that the symptoms don't make sense with typical CORS problems... |
My guess is that this is related to browsers supporting different max-package sizes. y-webrtc expects that messages with arbitrary length can be sent. This is, unfortunately, not the case. My standpoint is that this should be abstracted by the webrtc library. My recommendation is to extend the peerjs library to allow arbitrary message sizes between buffers. However, it is also necessary to research the exact problem and how browser vendors expected this to be implemented. |
Checklist
Describe the bug
The editor content is sync across the tabs of the same browsers.
But it does not sync with different browsers.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The editor content should be the same on different browsers.
Environment Information
The text was updated successfully, but these errors were encountered: