Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Storage and Local directories #842

Merged

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Added 2 new functions get_launcher_local_dir and get_launcher_storage_dir. One is used to get storage directory where addons and dependency packages are stored and the other where user/machine files are stored.

Additional info

The PR is related to changes in AYON launcher (PR ynput/ayon-launcher#144 ). The values are based on environment variable set during AYON launcher bootstrap, if are not set then previous implementation is used. This PR reduces usage of appdirs in ayon-core as those new functions should be used. Implementation is backwards compatible and new AYON launcher is not necessary.

Deprecation

  • Function get_ayon_appdirs was marked as deprecated.
  • Removed _create_local_site_id function which is not used anywhere and is dangling there for more than 4 months. The functionality happen in AYON launcher and it does not make sense to use it in ayon-core (it would be too late).

Testing notes:

  1. When using AYON launcher without the PR above it should still load addons.
  2. It should load addons even if you change addons directory with AYON_ADDONS_DIR to other place.
  3. When using AYON launcher with the PR above it should correctly use addons and dependency packages in bounds of related changes. One has to read that PR description to know them, for example changing AYON_LAUNCHER_STORAGE_DIR.
  4. More important part for ayon-core is that change of AYON_LAUNCHER_LOCAL_DIR will actually start to store user/machine specific files to different location, like console interpreter tabs or running tray information.

@ynbot ynbot added size/S type: feature Adding something new and exciting to the product labels Aug 9, 2024
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but anyone else should also test it.

@iLLiCiTiT iLLiCiTiT merged commit 38ddedb into develop Aug 15, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the feature/AY-5795_Ability-to-set-AYON-local-folder-location- branch August 15, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type: feature Adding something new and exciting to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants