Chore: Storage and Local directories #842
Merged
+101
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Added 2 new functions
get_launcher_local_dir
andget_launcher_storage_dir
. One is used to get storage directory where addons and dependency packages are stored and the other where user/machine files are stored.Additional info
The PR is related to changes in AYON launcher (PR ynput/ayon-launcher#144 ). The values are based on environment variable set during AYON launcher bootstrap, if are not set then previous implementation is used. This PR reduces usage of
appdirs
in ayon-core as those new functions should be used. Implementation is backwards compatible and new AYON launcher is not necessary.Deprecation
get_ayon_appdirs
was marked as deprecated._create_local_site_id
function which is not used anywhere and is dangling there for more than 4 months. The functionality happen in AYON launcher and it does not make sense to use it in ayon-core (it would be too late).Testing notes:
AYON_ADDONS_DIR
to other place.AYON_LAUNCHER_STORAGE_DIR
.AYON_LAUNCHER_LOCAL_DIR
will actually start to store user/machine specific files to different location, like console interpreter tabs or running tray information.