Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect current file ignore the default untitled scene when no save or load has happened yet #81

Merged

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Aug 28, 2024

Changelog Description

Never allow the "new" file (the standard scene) to be collected as current file

Additional info

This is a companion PR to ynput/ayon-core#786
When used together a better error report is shown for unsaved files.

image

(Screenshots from Houdini)

Testing notes:

  1. Use this PR together with Better validation report when publishing from unsaved workfile ayon-core#786
  2. Try publishing from an unsaved workfile
  3. Restart houdini (allow it to open last workfile) - it should correctly detect that you have a scene file open now

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Aug 28, 2024
@BigRoy BigRoy requested a review from MustafaJafar August 28, 2024 18:44
@BigRoy BigRoy self-assigned this Aug 28, 2024
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on my side for new files.
It doesn't work if my scene has unsaved changes.

image

@BigRoy
Copy link
Contributor Author

BigRoy commented Sep 4, 2024

It doesn't work if my scene has unsaved changes.

It doesn't work, because it fails/errors/crashes? Or just because it passes the validation.
If it passes validation, that's correct.
There hasn't been a requirement to have no unsaved changes.

@MustafaJafar
Copy link
Contributor

If it passes validation, that's correct.

it passes the validations if the workfile has unsaved changes.

@BigRoy
Copy link
Contributor Author

BigRoy commented Sep 4, 2024

That is the current correct behavior - if we want to change that it would be a new 'feature'. I personally won't be a fan. E.g. Blender integration does that and I hate it.

Anyway, does that mean we can resolve this conversation?

@MustafaJafar
Copy link
Contributor

That is the current correct behavior - if we want to change that it would be a new 'feature'. I personally won't be a fan. E.g. Blender integration does that and I hate it.

Anyway, does that mean we can resolve this conversation?

yes please, go ahead.

@BigRoy BigRoy merged commit 79ecd4a into ynput:develop Sep 5, 2024
1 check passed
@BigRoy BigRoy deleted the enhancement/houdini_detect_unsaved_file branch September 5, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants