Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop mode #61

Merged
merged 13 commits into from
Oct 19, 2023
Merged

Develop mode #61

merged 13 commits into from
Oct 19, 2023

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Oct 18, 2023

Changelog Description

Implemented support of develop mode in launcher. The launcher can skip distribution of addons by installing to addons dir, instead can use paths from server. And added disk remapping functionality.

Additional info

Added new flag argument --use-dev which will find bundle that is marked as dev bundle for the user who is logged in. It is also possible to start dev mode by passing bundle name which is set as dev bundle, in that case it does not check if user is assigned to it and blindly use it (handy for farm etc.).

Because settings variant is not as easy to define as used to be, it happens in the middle of distribution > that is because distribution is already preparing all the data needed for distribution itself.

Staging is completelly ignored if dev bundle should be used.

To be able to fully test the functionality it is necessary to have openpype addon with changes in this PR ynput/OpenPype#5783 .

Testing notes:

  1. Make sure you update venv (./tools/manage.ps1 create-env | ./tools/make.sh create-env)
  2. Make sure you have latest code of openpype addon on server from this PR AYON: Support dev bundles OpenPype#5783
  3. Make a build (or run from code)
  4. Enabled Develop mode on server (user must have enabled "is developer")
  5. Create develop bundle
  6. Assign your user to the bundle
  7. In the bundles tab, select the bundle, find openpype addon and enable dev path, and fill the path with path to openpype repository.
  8. Run launcher with ./ayon_console.exe --use-dev or ./ayon_console.exe --bundle <your dev bundle name>
  9. The addons from custom directories should be used

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working as expected. When running in developer mode the Ayon Launcher shows its icon in white
image

and Ayon server in developer mode set
image

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation but otherwise it works!

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Oct 19, 2023
@kalisp
Copy link
Member

kalisp commented Oct 19, 2023

Btw there could be a warning that disk mapping couldn't be created as target disk is already there.

@iLLiCiTiT
Copy link
Member Author

Btw there could be a warning that disk mapping couldn't be created as target disk is already there.

I would not do that. Mapping is executed on each launch and warning about existing disk on each start would cause only confusion.

@iLLiCiTiT iLLiCiTiT merged commit 97793f8 into develop Oct 19, 2023
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-6631_Launcher-in-dev-mode branch October 19, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants