Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure traypublisher context hierarchyContext get computed the same way than Hiero, Flame and Resolve #10

Open
2 tasks done
robin-ynput opened this issue Aug 29, 2024 · 0 comments
Assignees
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@robin-ynput
Copy link
Contributor

robin-ynput commented Aug 29, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

Currently ayon_traypublisher generates its hierarchyContext data via its own plugin:
https://github.com/ynput/ayon-traypublisher/blob/develop/client/ayon_traypublisher/plugins/publish/collect_shot_instances.py#L188

While Hiero, Flame and Resolve build up the same logic, leveraging ayon_core:
https://github.com/ynput/ayon-core/blob/6a07de6eb904c139f6d346fd6f2a7d5042274c71/client/ayon_core/plugins/publish/collect_hierarchy.py#L88

This has lead to false positives when I investigated stuff for Resolve, so I believe we could enforce a consistent and common method.

How would you imagine the implementation of the feature?

We would need to propagate ayon_traypublisher's traypublisher host so it uses Collect Hierarchy from ayon_core.

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

No response

@robin-ynput robin-ynput added the type: enhancement Improvement of existing functionality or minor addition label Aug 29, 2024
@robin-ynput robin-ynput self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

1 participant