Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message copy and behaviour change when ICP lead error #442

Open
harshita-srivastava-yral opened this issue Sep 19, 2024 · 2 comments · May be fixed by #443
Open

Message copy and behaviour change when ICP lead error #442

harshita-srivastava-yral opened this issue Sep 19, 2024 · 2 comments · May be fixed by #443
Labels
bug Something isn't working

Comments

@harshita-srivastava-yral
Copy link
Contributor

Whenever there is failure from ICP end and token doesn't get created:

  1. Remove the "Back to profile" CTA from the pop up
  2. Update the copy of the message on the Error pop up.

Subtext message : "Oops! There is some error from ICP's end. Please try again"
CTA - Retry

Please refer to the attached screenshot for the current error
Image
Image

@rupansh-sekar-yral
Copy link
Contributor

imo this is too early to implement and we should add logging/reporting around this before we remove the errors from UI.
There are many errors that can happen and so far only a subset of them are due to IC.
Lets properly analyse them and see where we can replace the message with something else.
Right now these error messages are indispensible for our debugging

@harshita-srivastava-yral
Copy link
Contributor Author

@rupansh-gob Aligned. Makes sense. I will create separate issue for error tracking...also we have event instrumented on FE around Creation failed, and it was really shocking to see that more creations are getting failed than successful...We will further add instrumentation to get an idea around the type of these errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants