From 1379f0482a3c1da0241fe4beef23fde1083766f1 Mon Sep 17 00:00:00 2001 From: sarvesh-sharma-yral Date: Mon, 2 Dec 2024 16:40:18 +0530 Subject: [PATCH 1/3] build: Adds swiftlint github action (#50) --- .github/workflows/swiftlint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/swiftlint.yml b/.github/workflows/swiftlint.yml index 776978c..f907ad0 100644 --- a/.github/workflows/swiftlint.yml +++ b/.github/workflows/swiftlint.yml @@ -2,7 +2,7 @@ name: SwiftLint on: pull_request: - types: [ready_for_review] + types: [opened, ready_for_review, synchronize] jobs: swiftlint: From 526394382023a107e440e6172a33f5a0e7b8ae2a Mon Sep 17 00:00:00 2001 From: sarvesh-sharma-yral Date: Mon, 2 Dec 2024 16:45:37 +0530 Subject: [PATCH 2/3] fix: Removes strict swift-lint requirement (#52) --- .github/workflows/swiftlint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/swiftlint.yml b/.github/workflows/swiftlint.yml index f907ad0..d4d51d7 100644 --- a/.github/workflows/swiftlint.yml +++ b/.github/workflows/swiftlint.yml @@ -16,4 +16,4 @@ jobs: - name: Run SwiftLint working-directory: iosApp - run: swiftlint --strict + run: swiftlint From c0a9299a455afb2f5305beeeffa6d7f6dcdd9411 Mon Sep 17 00:00:00 2001 From: sarvesh-sharma-yral Date: Mon, 2 Dec 2024 17:02:16 +0530 Subject: [PATCH 3/3] fix: Adds swiftlint strict param (#54) --- .github/workflows/swiftlint.yml | 2 +- iosApp/Generated/SwiftBridgeCore.swift | 1 + .../yral-mobile-swift-binding/yral-mobile-swift-binding.swift | 4 ++-- iosApp/iosApp/ContentView.swift | 1 - iosApp/iosApp/Extensions/SwiftBindings+Extensions.swift | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/swiftlint.yml b/.github/workflows/swiftlint.yml index d4d51d7..f907ad0 100644 --- a/.github/workflows/swiftlint.yml +++ b/.github/workflows/swiftlint.yml @@ -16,4 +16,4 @@ jobs: - name: Run SwiftLint working-directory: iosApp - run: swiftlint + run: swiftlint --strict diff --git a/iosApp/Generated/SwiftBridgeCore.swift b/iosApp/Generated/SwiftBridgeCore.swift index 8e2c317..5f6d2d3 100644 --- a/iosApp/Generated/SwiftBridgeCore.swift +++ b/iosApp/Generated/SwiftBridgeCore.swift @@ -1322,3 +1322,4 @@ extension Optional where Wrapped == Bool { __private__OptionBool(self) } } +// swiftlint:enable all diff --git a/iosApp/Generated/yral-mobile-swift-binding/yral-mobile-swift-binding.swift b/iosApp/Generated/yral-mobile-swift-binding/yral-mobile-swift-binding.swift index 8befb39..efe2d95 100644 --- a/iosApp/Generated/yral-mobile-swift-binding/yral-mobile-swift-binding.swift +++ b/iosApp/Generated/yral-mobile-swift-binding/yral-mobile-swift-binding.swift @@ -1,4 +1,5 @@ // swiftlint:disable all + public func get_secp256k1_identity(_ jwk_key: JwkEcKey) throws -> Secp256k1Identity { try { let val = __swift_bridge__$get_secp256k1_identity({jwk_key.isOwned = false; return jwk_key.ptr;}()); if val.is_ok { return Secp256k1Identity(ptr: val.ok_or_err!) } else { throw Secp256k1Error(ptr: val.ok_or_err!) } }() } @@ -34496,5 +34497,4 @@ extension ServiceRef { } } } - - +// swiftlint:enable all diff --git a/iosApp/iosApp/ContentView.swift b/iosApp/iosApp/ContentView.swift index 56309ed..06a9756 100644 --- a/iosApp/iosApp/ContentView.swift +++ b/iosApp/iosApp/ContentView.swift @@ -2,7 +2,6 @@ import SwiftUI import secp256k1 struct ContentView: View { - // let greet = Greeting().greet() var body: some View { Text("greet") diff --git a/iosApp/iosApp/Extensions/SwiftBindings+Extensions.swift b/iosApp/iosApp/Extensions/SwiftBindings+Extensions.swift index 36ed98f..55ead8f 100644 --- a/iosApp/iosApp/Extensions/SwiftBindings+Extensions.swift +++ b/iosApp/iosApp/Extensions/SwiftBindings+Extensions.swift @@ -17,7 +17,7 @@ extension PrincipalError: Error { } extension RustString: Error { - + } extension Secp256k1Error: Error {