-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.4.1 #110
Comments
I feel that the substantial additions made warrant a more substantial update.
|
What do you mean with a more substantial update? As far as I can think of, there were no breaking changes, so a minor release should be appropriate.
We should probably wait for a release until we merge the step line chart.
The derive macro is intended to simplify just some internal stuff, user facing code should not really be affected. There will probably be some breaking code changes, which will result in a major release, but they should be minimal. I am not familiar with writing proc macros, so I am hesitant on using this for now and hope to get someone to review it.
What do you have in mind? Would you like to have a changelog of important changes between the versions? |
Sorry, I thought these two PRs are low hanging fruits, but, clearly I have underestimated the amount of work still required to mature them.
I was looking dz! macro, which I feel more documentation might be able to help new user for a complete, end-to-end workflow, e.g. from csv (or xls) to plot, kinda "user-guide". Personally, I do read changelog to know more about what has changed. Rust has a standard CHANGELOG.md format. |
Nice to see updates again, i have a few small changes I'll contribute soon. I would prefer smaller updates. |
More documentation is always great but can be added later. I think the thorough examples you provided are good enough for now. I don't think there is a good general way to describe how to read and plot csv files. Reading csv files is documented very well, and plotting examples are plenty in this library. But there is no typical format we can generalize over. I would be happy to have a document of the changes, would you be interested in starting a CHANGELOG.md for the upcoming changes? |
If you need help or have any questions, just open an issue or start a discussion. |
I've submitted a PR to initiate the CHANGELOG.md file. Feel free to make any updates as needed; it's essentially a copy-paste from your list of changes. |
I added an SSR/Leptos wasm example in the discussions section here, feel free to use/copy it. |
Looking forward to the addition of step line support |
You can pick up the PR for the step line if you want. The author does not currently seem to want to implement the proposed changes. If you are interested, let me know, or I will tackle the small changes this week. |
Do we want to make a minor release?
From the top of my head, we added a lot of stuff.
The text was updated successfully, but these errors were encountered: