Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument calling HTMLObjectElement #17

Open
yuhao opened this issue May 6, 2016 · 2 comments
Open

Instrument calling HTMLObjectElement #17

yuhao opened this issue May 6, 2016 · 2 comments
Labels
good first bug missing feature

Comments

@yuhao
Copy link
Owner

yuhao commented May 6, 2016

An HTMLObjectElement is callable so typeof is function, and we will create function proxy for it, which is obviously problematic.
@yuhao
Copy link
Owner Author

yuhao commented May 7, 2016

Quick fix here. Need to come up with a better solution. Maybe it's time to seriously think about how to consolidate createObjProxy and createFuncProxy?

@yuhao
Copy link
Owner Author

yuhao commented May 10, 2016

This is a better fix. But we might still want to add the apply property of HTMLObjectElement's proxy because it's callable after all?

@yuhao yuhao changed the title Create proxy for HTMLObjectElement correctly Instrument calling HTMLObjectElement May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first bug missing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuhao