Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename funcEntry/Exit to domMethodEntry/Exit #33

Open
yuhao opened this issue May 18, 2016 · 1 comment
Open

Rename funcEntry/Exit to domMethodEntry/Exit #33

yuhao opened this issue May 18, 2016 · 1 comment
Labels
code health good first bug

Comments

@yuhao
Copy link
Owner

yuhao commented May 18, 2016

No description provided.

@yuhao
Copy link
Owner Author

yuhao commented May 19, 2016 •
edited
Loading

Maybe we were thinking about this wrong. The funcEntry interface does not intercept all functions, and it doesn't just intercept dom methods either. It is whatever function that is proxied. But it does include all invocations to dom methods. And similarly objGet/Set does include get and set to all nodes, style objs, etc.

Maybe what we should do it to provide specific APIs for domMethodEntry, styleObjBeforeGet, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health good first bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuhao