Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited but I haven't found a profitable arbitrage! #69

Open
M3sca opened this issue Apr 6, 2022 · 5 comments
Open

Edited but I haven't found a profitable arbitrage! #69

M3sca opened this issue Apr 6, 2022 · 5 comments

Comments

@M3sca
Copy link

M3sca commented Apr 6, 2022

Edited but I haven't found a profitable arbitrage!

I really appreciate what you have done but I'm not agree with what you have write.

I've edited your bot, I have removed 1inch API and add call directly with dex smartcontract quote.
I have done 1 to 1 swap.

I have run bot for several time but I never have found a profitable arbitrage!
I share an example:

1 USD Coin -> 0.99924 Tether USD [UNISWAP_V3]
1 USD Coin -> 0.99549 Tether USD [SUSHISWAP]
1 USD Coin -> 0.99407 Tether USD [QUICKSWAP]
1 USD Coin -> 0.99723 Tether USD [APESWAP]
1 USD Coin -> 0.99868 Tether USD [JETSWAP]
1 USD Coin -> 0.99818 Tether USD [POLYCAT]
1 USD Coin -> 0.99812 Tether USD [WAULTSWAP]

0.99924 Tether USD -> 0.99899 USD Coin [UNISWAP_V3]
0.99924 Tether USD -> 0.99774 USD Coin [SUSHISWAP]
0.99924 Tether USD -> 0.99918 USD Coin [QUICKSWAP]
0.99924 Tether USD -> 0.998 USD Coin [APESWAP]
0.99924 Tether USD -> 0.99855 USD Coin [JETSWAP]
0.99924 Tether USD -> 0.99623 USD Coin [POLYCAT]
0.99924 Tether USD -> 0.9971 USD Coin [WAULTSWAP]

@iouae
Copy link

iouae commented Apr 7, 2022

What a shame.

@Sshimaninja
Copy link

I'm trying convert this now to do direct quotes but I'm having a lot of trouble just getting prices from even one protocol. Any tips? I don't care if it's profitable anymore - I just want to achieve the goal of getting prices from DEXs for multiple tokens.

@M3sca
Copy link
Author

M3sca commented Apr 7, 2022

I'm trying convert this now to do direct quotes but I'm having a lot of trouble just getting prices from even one protocol. Any tips? I don't care if it's profitable anymore - I just want to achieve the goal of getting prices from DEXs for multiple tokens.

If you want to do this you can call the function 'getPriceOnUniV2' with this arguments:

  • @param tokenIn address of token to convert from
  • @param tokenOut address of token to convert to
  • @param amountIn amount of token to convert from
  • @param routerAddress router address

@Sshimaninja
Copy link

Yeah, that's the easy part. I'm trying to make it more complicated by adding UniV3 and passing in addresses from the objects in addresses.ts through config.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@Sshimaninja @iouae @M3sca and others