Change apiVersion to zalando.org/v1 #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
apiVersion
defined for theAWSIAMRole
CRD fromamazonaws.com/v1
tozalando.org/v1
.This is unfortunately a breaking change that we feel the need to make as we are preparing to roll this out in Zalando.
The reason to make this change is to ensure that Zalando as a company is not breaking any Trademark laws. While this project has been developed by me until now. As I'm an employee of Zalando and because of European Copyright laws, the copyright of the project falls to Zalando as this is related to my daily work. Therefore it makes sense to use
zalando.org/v1
instead of coming up with another name which may be trademarked by someone else.@seh already brought up this issue in the original PR.
Migration steps
Apply new CRD:
Copy old resources to new version:
Deploy new version of controller
>=0.1.0
(See https://github.com/mikkeloscar/kube-aws-iam-controller#setup).Delete old resources and old CRD:
If you are using RBAC, you also need to update the
ClusterRole
to havezalando.org
instead ofamazonaws.com
asapiGroups
.