-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] fix flake tests with image validation API errors #7989
base: dev
Are you sure you want to change the base?
Conversation
Adding the compliance namespace to the softfail list for the admission-controller doesn't seem to fix the issue for now, will investigate further. Update: Decided to update image references, let's see if it resolves the issue. |
👍 |
compliantImage5 = "container-registry.zalando.net/teapot/skipper:v0.21.4" | ||
compliantImage6 = "container-registry.zalando.net/teapot/skipper:v0.21.5" | ||
compliantImage7 = "container-registry.zalando.net/teapot/skipper:v0.21.6" | ||
compliantImage8 = "container-registry.zalando.net/teapot/skipper:v0.21.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These must be real images (i.e. the tag must exist and the image must be considered compliant or non-compliant (see images below) by docker-meta). The reason why there's so many test images is to ensure that the tests using them aren't affected by any caching because that can lead to wrong results.
Meaning we need 8 compliant and 10 non-compliant test images for the test cases or refactor the test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can look into this today, thanks for the review 🙏
E2e tests often fail because the image validation API return 502 return status, which causes the image admission to fail and the test fails.
Looking at docker-meta logs we see the base image has expired
This PR updates the compliant images so that the check doesn't fail.