Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to be done by accidental review #795

Closed
SmilyOrg opened this issue Feb 8, 2024 · 2 comments
Closed

Small fixes to be done by accidental review #795

SmilyOrg opened this issue Feb 8, 2024 · 2 comments
Assignees
@SmilyOrg

Comments

@SmilyOrg
Copy link
Member

SmilyOrg commented Feb 8, 2024

See #791 (review) for small problems found during a review by @tkrop on an unintentionally large diff due to a missing proper merge / rebase.
@SmilyOrg SmilyOrg mentioned this issue Feb 8, 2024
Merged
@SmilyOrg
Copy link
Member Author

SmilyOrg commented Mar 5, 2024

@SmilyOrg extract small problems from the review and open PR if easy

tkrop pushed a commit that referenced this issue Mar 21, 2024
fix: asciidoc build to run as user (#795)
972ed8f 
Signed-off-by: Tronje Krop <[email protected]>
@tkrop
Copy link
Member

tkrop commented May 28, 2024

I think this is resolved by #795.

@tkrop tkrop closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SmilyOrg SmilyOrg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SmilyOrg @tkrop