Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing section on quality of service and rate limits ? #809

Open
julienlau opened this issue May 13, 2024 · 2 comments
Open

missing section on quality of service and rate limits ? #809

julienlau opened this issue May 13, 2024 · 2 comments
Assignees

Comments

@julienlau
Copy link

Hi,
Thanks for sharing this documentation.
I am bit surprised that there is nothing related to quality of services ?
Don't you consider rate limiting as something required out of the box for any API ?

Regards

@tkrop
Copy link
Member

tkrop commented May 28, 2024

@julienlau sorry for the late reply.

Yes, we intentionally left out service operation aspects, when we created this API guideline over 8 years ago, and concentrated on the technical aspects that need to be included in the API. So we just created rules like rule 153 to defining technical how a rate limit must be specified and added a section about performance aspects. In the last years we started to add best practice tips where we saw value, but this up-to-now does not include quality-of-service.

May be the reason for this is, that we are using our own ingress router Skipper, which allows us to simply configure rate-limits for our services while our own Kubernetes on AWS takes care to scale our micro-services smoothly.

@tkrop tkrop assigned vadimturkov and unassigned tkrop Jul 9, 2024
@tkrop
Copy link
Member

tkrop commented Jul 9, 2024

We will add some more remarks on the internal tooling for rate-limiting we use. Since it is open source and provides open source documentation, we think that Zalando as well as public contributors will profit from giving some more information about rate-limiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants