You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should we keep TFHEExecutor without events the default version? This is good to save around 5% gas, but some of our partners want to use the TFHEExecutorWithEvents as the default version, and we use this version at the moment in mocked mode to get faster mocked coprocessor (we als have a mocked for the version without events using tracing but it is 100x slower).
Code refactoring / best practise.
Use of custom errors instead of revert strings to save some gas.
We should also add more unit tests, for exemple the codegen does not sample uintXX types in good ranges for some of them.
Add coverage metric for core contracts testing.
Use Slither to get security warnings from static analysis.
Test different solc settings to improve gas consumption from users. It might make sense to make viaIR the default settings of the compiler to save easily 3-4% of gas for users, but this unfortunately makes the TFHEExecutor contract too big for deployment.
Should we merge the InputVerifier contract with ACL to save gas?
Should we get rid of proxies to save gas? Might be risky because upgrades will become impossible.
Maybe adding smart contracts fuzzing? What invariants should be asserted in our code? At least it will force us to think more deeply about security.
The text was updated successfully, but these errors were encountered:
I also think that interfaces must be managed differently.
For instance, TFHEExecutor doesn't inherit ITFHEExecutor, ACL doesn't inherit IACL, etc.
It would be best to import/inherit the interfaces in TFHEExecutor, ACL, KMSVerifier.
I also think that interfaces must be managed differently.
For instance, TFHEExecutor doesn't inherit ITFHEExecutor, ACL doesn't inherit IACL, etc. It would be best to import/inherit the interfaces in TFHEExecutor, ACL, KMSVerifier.
Non exhaustive list of general improvements:
The text was updated successfully, but these errors were encountered: