Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round bracket in WiFi name disturbs trusted network identification #363

Closed
jkrwdf opened this issue Sep 24, 2024 · 4 comments
Closed

Round bracket in WiFi name disturbs trusted network identification #363

jkrwdf opened this issue Sep 24, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jkrwdf
Copy link

jkrwdf commented Sep 24, 2024

Describe the bug
Since the update to version 3.5.2, my home network was no longer recognized as trusted and the auto-tunnel kicked in.
My home network is named

FOOBAR (5 GHz)

I believe the bug happens because with the new version, wildcard support based on regex was implemented, and the round brackets have a meaning there.

Experiment: When I change my trusted network entry in WG tunnel to either

FOOBAR*
FOOBAR \(5 GHz\)

it works again.

Smartphone (please complete the following information):

  • Device: Google Pixel 4a (5G)
  • Android Version: 14
  • App Version 3,5,2
@jkrwdf jkrwdf added the bug Something isn't working label Sep 24, 2024
@zaneschepke
Copy link
Owner

Hello! Thanks for reporting this. I'll look into a fix for this.

@Scorpoon
Copy link

Thanks to OP for the hint with escaping the special characters xD
I could've thought about it myself because I often do it in C# 😂

@zaneschepke
I guess you could handle it by defining your own matching pattern (f.e. instead of "!" the end user has to use "((!))") and before evaluating the wildcard escape the normally used ones for example with " " (excluding own matching pattern) and after that replace "((!))" again with "!".
Just my first thought about how it could be handled without confusing the end user too much.

@jkrwdf
Copy link
Author

jkrwdf commented Nov 11, 2024

Yesterday I updated to version 3.6.0 which addresses this issue by introducing a new switch "Use name wildcards" by which the user can choose whether the content of the "Trusted wifi names" is literal strings (switch "off") or may contain (regex)-syntax (switch "on") and in this case a help-page explains how to handle special characters in the wifi name.

This issue can therefore be closed.

A tiny remark may be allowed: I had solved my issue by using a wildcard and maintained FOOBAR*.
After the upgrade, I immediately noted that without me doing anything, the tunnel was unwantedly coming up.
Reason is that the new switch "Use name wildcards" is delivered by default with state "off", and that affects everyone who adapted his settings after the last update in September. Eventually in this situation (first start after upgrade, and wifi names contain wildcards) a toast-message would be useful.

@zaneschepke
Copy link
Owner

Thanks for these details! Noted on the breaking change, I'll try to look to add something in the future that makes people aware of these breaking changes. Marking as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants