Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Changes to README or RELEASE_NOTES triggers unwanted checks #78

Open
hiimjako opened this issue Jan 9, 2024 · 7 comments
Open
Labels
bug This issue/PR relates to a bug.

Comments

@hiimjako
Copy link
Contributor

hiimjako commented Jan 9, 2024

Describe the bug

It is annoying that when an update is made only to the release notes or readme all the checks are relaunched. Just the syntaxcheck and Markdown ones would be enough.
it would be nice to avoid having to wait minutes for build even if only the readme was changed

Expected Behavior

Only Markdown and syntaxcheck should re-run

Steps To Reproduce

  • Open a PR in a golang repository
  • Push a commit with a README or RELEASE_NOTE change
  • All checks triggers

Exceptions (if any)

No response

Version

main

@hiimjako hiimjako added the bug This issue/PR relates to a bug. label Jan 9, 2024
@hiimjako
Copy link
Contributor Author

Also, an annoying thing, which I don't know if it can be solved, is that every time you want to merge a Dependabot PRs there is to manually fix the release note because there are always conflicts, I don't know if there is a way to avoid that (Like telling him to always accept the current), so that the checks can restart without human input

@chicco785
Copy link
Member

If dependabot would allow to create pr as draft, that would solve in combination with blocking the release note generation if not final. Alternative could be generating release note only on merge, but I am not so happy about the idea, because the approval of the check of the log in the release note, for me is part of the review process.

@chicco785
Copy link
Member

chicco785 commented Jan 11, 2024

you can see how the merge of the pr #72
would affect a repository here: https://github.com/zaphiro-technologies/architecture/pull/164

I am not saying is the best solution, but it's a progress.
A more definitive solution (for this issue and any other issue related to useless cyclic action on not changed code) is to modify https://github.com/dorny/paths-filter to raise only changes between current and previous commit. This requires anyhow much more time.

So please, unless you have any other idea that preserve quality of the process, review, and merge the pr #72 so that we can at least mitigate the issue.

Thx

@chicco785
Copy link
Member

The wf now is generating release note only on approval, this may solve the issue with dependabot as well.

@chicco785
Copy link
Member

for go builds, a similar approach using https://github.com/dorny/paths-filter to trigger build only on the change of go / test data should be followed. the pattern for files, need to support configuration since it may be specific to the project (because for example test data are in different format / locations in different projects).

@chicco785
Copy link
Member

chicco785 commented Feb 9, 2024

@zaphiro-technologies/platform with last merged PRs markdown wf runs only if and md file is changed and pr is not draft, while release note wf are triggered only when a pr is approved.

Warning

This means that before merging you have to wait them to complete.

@chicco785
Copy link
Member

@hiimjako the generation only on approval of release notes, should solve the dependabot issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants