Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage off in test_zarr3.py #636

Closed
jakirkham opened this issue Nov 13, 2024 · 2 comments
Closed

Coverage off in test_zarr3.py #636

jakirkham opened this issue Nov 13, 2024 · 2 comments

Comments

@jakirkham
Copy link
Member

It looks like test_zarr3.py is falling below coverage. Not sure what is expected to be covered or not here. So flagging it in an issue

https://app.codecov.io/gh/zarr-developers/numcodecs/blob/main/numcodecs%2Ftests%2Ftest_zarr3.py

@jakirkham
Copy link
Member Author

Looks related to recent type hinting work in PR: #460

@dstansby do you know how we should handle this? Do we need to skip coverage on some lines or should they actually be covered somehow?

@dstansby
Copy link
Contributor

These lines should be fixed by #633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants