Deprecate blosc helper functions #619
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
deprecate-blosc
branch
from
b6f6461
to
5ab921c
Compare
normanrz
reviewed
Nov 9, 2024
| """Initialize the Blosc library environment.""" | ||
| blosc_init() | ||
|
|
||
| init = deprecated(_init) |
There was a problem hiding this comment.
I guess decorators don't work in .pyx files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a pre-requisite for depending on pre-built
bloscwheels (see #571, #262, #464), this deprecates several functions. The idea would be to have one deprecation cycle (say numdocecs 0.14), then remove the public functions in the next release (say numcodecs 0.15).This uses the
deprecatedlibrary to handle the deprecations, which does add a nother dependency, but it is quite lightweight.