Refactor: store mode and initialization #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys
…into feature/store_erase_prefix
…python into feature/store_erase_prefix
…into feature/store_erase_prefix
8 tasks
jhamman
commented
Oct 28, 2024
src/zarr/abc/store.py
Outdated
Comment on lines
32
to
33
| assert mode in ("r", "w") | ||
| self._mode = mode |
There was a problem hiding this comment.
we may consider a different setting here (e.g. readonly)
There was a problem hiding this comment.
I generally prefer the attribute matching the parameter name.
We can have a property
@property
def readonly(self): return self.mode == "r"
Edit: which I see you have down below.
d-v-b
reviewed
Oct 29, 2024
d-v-b
reviewed
Oct 29, 2024
d-v-b
reviewed
Oct 29, 2024
d-v-b
reviewed
Oct 29, 2024
d-v-b
reviewed
Oct 29, 2024
d-v-b
reviewed
Oct 29, 2024
d-v-b
reviewed
Oct 29, 2024
Co-authored-by: Davis Bennett <[email protected]>
…into refactor/store-mode
…into refactor/store-mode
…into refactor/store-mode
TomAugspurger
approved these changes
Nov 12, 2024
d-v-b
reviewed
Nov 12, 2024
d-v-b
reviewed
Nov 12, 2024
d-v-b
reviewed
Nov 12, 2024
d-v-b
reviewed
Nov 12, 2024
d-v-b
reviewed
Nov 12, 2024
d-v-b
reviewed
Nov 12, 2024
|
Thanks folks for the reviews here! |
6 tasks
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, opening a store in
wmode, had a side effect (Store.clear). That was leading to unexpected behavior when apathargument was also supplied. This refactor takes the following approach:keepsStore.modebut allows this to be onlyStoreAccessMode = Literal["r", "w"]Store.modewithStore.read_onlyStorePath.open(..., mode: AccessModeLiteral)where side effects can be applied at the path levelbuilds on #2430
closes #2359
TODO: