Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multiple instances] Modal Warning "Only one instance..." message is annoying #245

Open
vodihu opened this issue Jul 20, 2022 · 7 comments · Fixed by #262
Open

[multiple instances] Modal Warning "Only one instance..." message is annoying #245

vodihu opened this issue Jul 20, 2022 · 7 comments · Fixed by #262
Assignees
Labels
bug Pesky little gritter, needs squashing
Milestone

Comments

@vodihu
Copy link

vodihu commented Jul 20, 2022

I like to have only one instance of Logexpert, as settings "view Settings => Allow only 1 Instance" assume. But I could not get rid of this annoying Messagebox.

  • LogExpert Version: 1.9.0
  • Windows Version: 11

image

Thanke you very much, for keeping Logexpert alive!

@Hirogen
Copy link
Collaborator

Hirogen commented Jul 20, 2022

Ah I see, problem is, you get the error message always, even after the first time, that is quite annoying.

The Message comes from the newly started instance, so not quite sure yet how to make the message only popup once

Thanke you very much, for keeping Logexpert alive!

No problem, I use it daily at my work place, that's one of the many reasons I try to keep it alive and supported

@Hirogen Hirogen added the bug Pesky little gritter, needs squashing label Jul 20, 2022
@Hirogen Hirogen self-assigned this Jul 20, 2022
@Hirogen Hirogen added this to the Release 1.9.1 milestone Jul 20, 2022
@GeneralMidiRotkiv
Copy link

I second the notion to get rid of this modal so that it doesn't pop up every time a new tab/instance is started. Maybe you could add a "Don't show again" checkbox and link it to a settings file?
Anyways, also thanks from my side for putting in the work, it's a great program!

@Hirogen Hirogen linked a pull request Aug 19, 2022 that will close this issue
@hugosius
Copy link

Also for me, this message is not useful in any way. A "Don't show again" option as suggested by @GeneralMidiRotkiv would do just fine.
Besides, LogExpert is a great an very helpful tool. Thanks for that!

@SNaatanen
Copy link

In my mind "Don't show again" approach is sub optimal too.
Using UI principals it would be OK to offer the popup warning/info, but only once so the popup should have button that has text like "OK, I understand".
After clicking that no popups will be shown as long as the "Only one instance" setting has not been altered by the user.

@Hirogen
Copy link
Collaborator

Hirogen commented Dec 19, 2022

It is fixed, but currently the Settings-Dialog does not import the Settings when it is opened, only when Logexpert is started, this needs to be taken into account, so the "option" to "not show the error message" has currently a wrong state in the settings dialog.

@pferrucci
Copy link

+1
This is new in 1.9.0
With previous version, running "Logexpert myfile" would open it in a new tab. That was nice.
Waiting for a new binary release if it was fixed.

Thanks

@hugosius
Copy link

hugosius commented May 4, 2023

We would also appreciate a new release since the issue seems to be fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Pesky little gritter, needs squashing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants