Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Balances #16

Closed
2 of 4 tasks
dexX7 opened this issue Feb 12, 2015 · 11 comments
Closed
2 of 4 tasks

UI: Balances #16

dexX7 opened this issue Feb 12, 2015 · 11 comments

Comments

@dexX7
Copy link

dexX7 commented Feb 12, 2015

2_balances

  • 2) Highest priority: right-click -> "copy address" or "send from this address" Edit: UI 0.0.9.2 UI: Balances: context-menu actions #33
  • 3) The behavior of resizing the colums feels very odd, and the seperator between "address" and "reserved" can't be moved.
  • 4) Sorting columns, similar to the Bitcoin transaction histoy would be great. Edit: UI 0.0.9.2 UI: Balances: sort columns #32
  • 5) I'm not sure about it, but my first impression was that "available" should be left to "reserved". This is very vague though. edit: too vague and probably wrong anyway
@dexX7
Copy link
Author

dexX7 commented Feb 12, 2015

Regarding 3, here is an example where not the full balance is visible, because the width of "available" can't be increased:

3_send_1

@zathras-crypto
Copy link
Owner

Increase 'Available' with the adjuster on the right of the column header -
agreed seems un-intuitive - on the todo list :)

On Thu, Feb 12, 2015 at 6:01 PM, dexX7 [email protected] wrote:

Regarding 3, here is an example where not the full balance is visible,
because the width of "available" can't be increased:

[image: 3_send_1]
https://cloud.githubusercontent.com/assets/5836089/6163065/4007a6be-b28d-11e4-978e-ae025f3fa454.png


Reply to this email directly or view it on GitHub
#16 (comment)
.

@zathras-crypto
Copy link
Owner

Regarding 2) - I understand the value in 'send from this address' but 'copy address' is of little use in sending (you can't paste into 'send from' in the send dialog) - shame because that's the easier of the two to implement hehe... Let me investigate this one

@zathras-crypto
Copy link
Owner

Some things I'd like to defer to a 0.0.9.2 UI release (which can come soon, won't be a required upgrade) so could you do me a favour? For new issues please address one item per issue - then I can use a few labels I just created to categorize into quick items I can do for 0.0.9.1 and other items I'll defer to next minor release.

@zathras-crypto
Copy link
Owner

2/4 likely defer to 0.0.9.2
3 will address for 0.0.9.1

@dexX7
Copy link
Author

dexX7 commented Feb 13, 2015

'copy address' is of little use

Consistency is also important in my opinion, and it's available basically everywhere else where addresses are involved.

I see the dilemma though, given that the combobox is either readonly and it's not possible to paste values into it, or it's fully editable and probably no way to handle the input properly, I assume.

For new issues please address one item per issue

Yes, very good idea. I started with the screenshots, then had the idea with the issues and check marks, and this is the perfect extension of it. :)

@zathras-crypto
Copy link
Owner

Just a quick note to say still working on the balances stuff. Basically the issue is that when using QHeaderView::Stretch or QHeaderView::ResizeToContents these block user resizing of the columns. So I'm now using QHeaderView::Interactive on everything and resizing in code which provides the required movements, but making the stretch manually is awkward and is lost obviously when window is resized. I'm trying to reuse some stuff from GUIUtil that the Bitcoin guys use, but most of that functionality is hardcoded for the Bitcoin tx history column layout (specifically always stretching 2nd to last column which doesn't work for us). My own implementation of that sadly segfaulted due to the way I'd overridden the resize and paint events of the form and it was getting kind of hacky. Anyway just a quick update, still working on it, currently moving to a model where I reuse same functions in GUIUtil at the way the bitcoin guys do it but I modify them to be adaptable to different column layouts. Will let you know when I have something working to commit :)

Thanks
Z

@zathras-crypto
Copy link
Owner

OK, give 8bfb0d3 a whirl and let me know what you think.

Thanks
Z

@dexX7
Copy link
Author

dexX7 commented Feb 14, 2015

Haha this is so much better, thanks a lot! :) Last note for this page: "available" and "reserved" should be right, not left aligned in my opinon.

@zathras-crypto
Copy link
Owner

Great :) Re right aligned numbers, yep oversight will fix that should be easy enough :)

@zathras-crypto
Copy link
Owner

Right align amounts on balances tab b0b9231

Thanks
Z

@dexX7 dexX7 closed this as completed Feb 16, 2015
zathras-crypto pushed a commit that referenced this issue May 20, 2015
dc7c594 Move project files into src/omnicore/ and src/omnicore/test/ (dexX7)
06369cb Update header include guards and test suite names (dexX7)
3cfb5dc Include Omni Core via seperate Makefiles (dexX7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants