Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contest scoreboard to properly color AC submissions green (#31) #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SuperCl4sh
Copy link

Fixes #31.

@SuperCl4sh
Copy link
Author

SuperCl4sh commented Mar 16, 2022

Looking at each of the contest formats, there appears to be the exact same display_user_problems functions in them. Perhaps it might be worth removing them, then simply importing them from default.py. Alternatively, since the the default contest is passed as a constructor for each of the contest formats, super() could be used. This would reduce code redundancy while optimizing future code updates to this function.

@zecookiez
Copy link
Owner

Can you send a screenshot from your testing? This looks okay but I don't know if there are any existing scoreboards on the platform that have this issue.

@SuperCl4sh
Copy link
Author

This is before the changes:
image

This is after the changes:

image

An example on the site can be found here.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contest scoreboard display issues
2 participants